feat: add CEL-backed rich assigns to state/expr#86
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CEL-backed rich assigns to
state/expr, the write-side companion to rich guards.expr.Assign(reg, name, source, schema)compiles a CEL expression that evaluates to a map of context field updates and registers it as an assign reducer the kernel folds inside Fire — referenced from a transition with theAssignverb (orOnEntryAssign/OnExitAssign) exactly like a Go reducer. Compilation and type-checking happen once at authoring time, against the same schema-derived environment guards read; the result type must be a string-keyed map or authoring fails loudly. At run time the reducer evaluates the expression over the prior context, then merges the resulting updates onto a copy via the same JSON projection as the read path (a shallow top-level overlay), staying total and pure: a type-mismatched update or rare runtime eval error leaves the context unchanged. With a Catalog the type-checked AST is collected for tooling/polyglot transport, like guards. Reads the context only (event access is a clean additive follow-up). The expr coverage floor moves 90→88 with a documented rationale: the total-reducer contract introduces unreachable defensive swallow-branches. Additive; stdlib-plus-CEL (no new deps).